Fix audit vulnerabilities and Puppeteer WDAC block on managed dev machines - #96
Merged
Hector Hernandez (hectorhdzg) merged 1 commit intoAug 11, 2026
Conversation
…hines Security (package-lock.json): - Apply non-breaking `npm audit fix` (24 -> 17 vulnerabilities); resolves brace-expansion, fast-uri, morgan and shell-quote advisories. - Normalize lockfile `resolved` URLs back to https://registry.npmjs.org/ so external contributors and public CI are not pinned to an internal npm mirror. - Remaining advisories are dev-only, transitively pinned by react-native@0.69 (jscodeshift/micromatch/braces, ip, image-size, metro, react-devtools-core) and would require a breaking react-native major upgrade, so they are left as-is. Puppeteer (gruntfile.js): - Add a CI-gated helper that resolves the QUnit browser test executable to a locally installed Edge when available, avoiding the Windows "blocked by IT admin" (Defender/WDAC) popup triggered by Puppeteer's unsigned bundled Chromium on managed developer machines. - Honors PUPPETEER_EXECUTABLE_PATH first and returns undefined on CI/official builds (TF_BUILD/CI/BUILD_BUILDID) so bundled Chromium behavior is unchanged. - Wire executablePath into both puppeteer test blocks.
Radhika Gupta (rads-1996)
approved these changes
Aug 11, 2026
Jackson Weber (JacksonWeber)
approved these changes
Aug 11, 2026
Hector Hernandez (hectorhdzg)
merged commit Aug 11, 2026
51d2c2d
into
microsoft:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security (package-lock.json):
npm audit fix(24 -> 17 vulnerabilities); resolves brace-expansion, fast-uri, morgan and shell-quote advisories.resolvedURLs back to https://registry.npmjs.org/ so external contributors and public CI are not pinned to an internal npm mirror.Puppeteer (gruntfile.js):