Fix WPF Gallery navigation text overlapping scrollbar at 200% text scaling#799
Open
wnvko-msft wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In WPF Gallery, navigation pane labels (e.g. "File and Folder Dialogs") overlap the vertical scrollbar when Windows text scaling is set to 200%. Fixes ADO 3017671.
Cause
The Fluent theme's vertical scrollbar is a 12px overlay drawn on top of the content's right edge. The auto-sized nav pane grows to fit each item's text, but the overlay scrollbar still covers the last characters of the widest label - made worse at 200%.
Fix
Reserve 16px of right-side space on the nav item content in
MainWindow.xamlso the pane accounts for the scrollbar and the overlay covers the margin instead of the text.Microsoft Reviewers: Open in CodeFlow