Fix MessageBox dialogs not adapting to dark mode in WPF Gallery#793
Open
amarinov-msft wants to merge 1 commit into
Open
Fix MessageBox dialogs not adapting to dark mode in WPF Gallery#793amarinov-msft wants to merge 1 commit into
amarinov-msft wants to merge 1 commit into
Conversation
The native Win32 MessageBox does not honor the app's Fluent ThemeMode, so dialogs stayed light in dark mode and failed contrast requirements. Add a Fluent-themed ThemedMessageBox (WPF Window) that inherits the app theme and route the MessageBox page's dialogs through it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an accessibility issue in the WPF Gallery Message Box page. Dialogs shown via
System.Windows.MessageBox.Show(...)render as the native Win32 message box, which does not honor the app's FluentThemeMode. In Dark mode the dialog stays light, so its text renders below the 4.5:1 contrast minimum required by MAS 4.3.1 and is flagged by Accessibility Insights. This is a platform limitation:MessageBox.ShowCorecalls the user32MessageBox, and the Fluent theme has no template for it, so the dialog cannot adapt to the app theme.Change
Sample Applications/WPFGallery/Controls/ThemedMessageBox.xaml / .xaml.csAdd a Fluent-themed
ThemedMessageBox(a WPF Window) that inherits the application theme, so it adapts to Light/Dark/High Contrast automatically. It reuses the platform's own message-box brushes (MessageBoxBackground,MessageBoxForeground,MessageBoxSeparatorBorderBrush,MessageBoxTopOverlay) andSymbolThemeFontFamilyfor the severity icon.Sample Applications/WPFGallery/Views/System/MessageBoxPage.xaml.csRoute the page's 7 dialog call sites through
ThemedMessageBoxinstead ofSystem.Windows.MessageBox.Result
In Dark mode the message-box dialogs now render with the app's dark background and full-contrast Fluent foreground. Light and High Contrast appearance follow the app theme as well. Button semantics and returned
MessageBoxResultvalues are preserved.Testing
Microsoft Reviewers: Open in CodeFlow