Avoid wrapping the queued function in an extra closure in parallelWorkGroup - #63898
Draft
no-yan wants to merge 1 commit into
Draft
Avoid wrapping the queued function in an extra closure in parallelWorkGroup#63898no-yan wants to merge 1 commit into
no-yan wants to merge 1 commit into
Conversation
…kGroup Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
typescript-automation
Bot
added
the
For Uncommitted Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series reducing allocation churn on hot paths (see #63895).
parallelWorkGroup.Queuewrapped each queued function in an extraclosure before handing it to the WaitGroup.
sync.WaitGroup.Go(Go 1.25+) already does the Add/Done bookkeeping, so pass
fnthroughdirectly — one less closure allocation per queued task.
Output on a full vscode/src check is byte-identical to main.
🤖 Generated with Claude Code