feat: add UploadSource to ClientExtractedMetaData for XVC1 uploads#132
Open
RafaelHinojosa wants to merge 1 commit into
Open
feat: add UploadSource to ClientExtractedMetaData for XVC1 uploads#132RafaelHinojosa wants to merge 1 commit into
RafaelHinojosa wants to merge 1 commit into
Conversation
Include UploadSource in the package creation request body (ClientExtractedMetaData) so downstream services (Xbox.Xbet.Service / LogAnalytics) can identify the originating tool (PackageUploader, XGPM, or makepkg2). Changes: - Add UploadSource nullable property to ClientExtractedMetaData - Add makepkg2 to UploadSourceConfig allowlist - Pass validated _uploadSource from HttpRestClient to the builder - Expose MakePkg2UploadSource public constant for external consumers - Add ~30 tests covering builder, serialization, HTTP flow, and edge cases - Add design document (docs/uploadsource-client-extracted-metadata.md) No changes to MSIXVC2 flow, public interfaces, or HTTP header behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include UploadSource in the package creation request body (
ClientExtractedMetaData) for XVC1 uploads, so downstream services (Xbox.Xbet.Service / LogAnalytics) can identify the originating tool.Values
PackageUploader— CLI tool (default)XGPM— Xbox Game Package Manager UImakepkg2— via packagingservices.dll (pending external integration)null— omitted from JSON when not setChanges
UploadSourcenullable property toClientExtractedMetaDatamakepkg2toUploadSourceConfigallowlist_uploadSourcefromHttpRestClientto the builderMakePkg2UploadSourcepublic constant for external consumersdocs/uploadsource-client-extracted-metadata.mdWhat is NOT changed