Skip to content

add unittest validing mobidus with OnnxDiscrepancyCheck#2567

Merged
tadani3 merged 5 commits into
mainfrom
xadupre/mobius
Jul 18, 2026
Merged

add unittest validing mobidus with OnnxDiscrepancyCheck#2567
tadani3 merged 5 commits into
mainfrom
xadupre/mobius

Conversation

@xadupre

@xadupre xadupre commented Jul 10, 2026

Copy link
Copy Markdown
Member

Describe your changes

Make sure there is a test validating the mobius export path and OnnxDiscrepancyCheck.

@xadupre

xadupre commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

@copilot fix lint

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@copilot fix lint

Fixed in a4cc294.

@xadupre

xadupre commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

@copilot test/passes/onnx/test_session_params_tuning.py:174: in test_ort_session_params_tuning_pass_with_dynamic_shapes
assert "ones() received an invalid combination of arguments" in str(e.value)
E assert 'ones() received an invalid combination of arguments' in "ones(): argument 'size' (position 1) must be tuple of ints, but found element of type str at pos 0"
E + where "ones(): argument 'size' (position 1) must be tuple of ints, but found element of type str at pos 0" = str(TypeError("ones(): argument 'size' (position 1) must be tuple of ints, but found element of type str at pos 0"))
E + where TypeError("ones(): argument 'size' (position 1) must be tuple of ints, but found element of type str at pos 0") = <ExceptionInfo TypeError("ones(): argument 'size' (position 1) must be tuple of ints, but found element of type str at pos 0") tblen=10>.value

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@copilot test/passes/onnx/test_session_params_tuning.py:174: in test_ort_session_params_tuning_pass_with_dynamic_shapes
assert "ones() received an invalid combination of arguments" in str(e.value...

Fixed in 94bc3c9.

@xadupre

xadupre commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Fixed in 18ccfb4.

@xadupre

xadupre commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Fixed in e82ba38.

@xadupre
xadupre marked this pull request as ready for review July 17, 2026 12:43
Copilot AI review requested due to automatic review settings July 17, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds unit test coverage to ensure OnnxDiscrepancyCheck’s generation-comparison path correctly auto-detects ORT GenAI exporter artifacts produced by MobiusBuilder (via presence of genai_config.json) and behaves consistently with the existing ModelBuilder-based flow.

Changes:

  • Add tests verifying a Mobius export directory containing genai_config.json is used as genai_model_path for generation metrics.
  • Add a test ensuring the first_token_20 metric forces max_new_tokens=20 when running generation comparison.
  • Add a test ensuring generation comparison is skipped when a Mobius export directory lacks genai_config.json.

@tadani3
tadani3 merged commit 9f658d5 into main Jul 18, 2026
13 checks passed
@tadani3
tadani3 deleted the xadupre/mobius branch July 18, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants