Fix ActivateInstance parameter#2476
Open
manodasanW wants to merge 3 commits into
Open
Conversation
…o the default interface but rather could be IInspectable
|
Can we get more background (if any) on this and potentially edit the docs https://learn.microsoft.com/windows/win32/api/activation/nf-activation-iactivationfactory-activateinstance |
|
@oldnewthing https://devblogs.microsoft.com/oldnewthing/20201028-00/?p=104404 and https://devblogs.microsoft.com/oldnewthing/20200324-00/?p=103586 make claims about object representation "at the ABI" that could use some clarification. (These articles came up in a discussion about this issue.) My suspicion is that you were describing ABI behavior from a C++/WinRT-authored-component perspective, rather than stating overarching rules for all WinRT objects right? |
Sergio0694
reviewed
Jun 28, 2026
Sergio0694
approved these changes
Jun 29, 2026
Introduce an overload of WindowsRuntimeActivationHelper.ActivateInstanceUnsafe that accepts an IID and returns the default interface pointer. The new method activates the factory to get an IInspectable, queries for the requested interface via QueryInterface, and releases the temporary IInspectable. It preserves HRESULT handling via RestrictedErrorInfo and uses NoInlining attribute. This enables callers using the parameterless constructor path to obtain the actual default interface from activation factories.
Simplify sealed-type activation by having WindowsRuntimeActivationHelper.ActivateInstanceUnsafe return the default interface directly. Removes manual QueryInterface/Release logic and related temporary pointer handling, reducing complexity and potential lifetime errors during activation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ActivateInstance parameter to reflect that it is not guaranteed to be the default interface but rather could just be IInspectable