Fix const-correctness in ggml_vec_dot_i2_i8_s_Nx1 (Clang 18)#577
Open
marcosmmorato-byte wants to merge 1 commit into
Open
Fix const-correctness in ggml_vec_dot_i2_i8_s_Nx1 (Clang 18)#577marcosmmorato-byte wants to merge 1 commit into
marcosmmorato-byte wants to merge 1 commit into
Conversation
y_col estaba declarado como int8_t* pero se inicializaba desde un puntero const (y), lo cual falla al compilar con Clang 18.1.8 (toolset ClangCL de VS2022 BuildTools en Windows).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
y_colwas declared asint8_t*but initialized fromy, which isconst int8_t*. This fails to compile under stricter Clang versions(e.g. Clang 18.1.8, bundled with the VS2022 Build Tools ClangCL
toolset used on Windows).
Minimal type fix, no behavior change.