Handler config fix - #77
Merged
Merged
Conversation
Axel Suárez (axelsrz)
marked this pull request as ready for review
July 28, 2025 22:50
Rodrigo Brandão (rodrigobr-msft)
approved these changes
Jul 28, 2025
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Jul 28, 2025
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Jul 28, 2025
Rodrigo Brandão (rodrigobr-msft)
pushed a commit
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes fixes to logging and configuration handling in the
microsoft-agents-hosting-corelibrary. The most important changes address a typo in a logger call and improve the robustness of authorization handler initialization.Logging Fix:
ogger.error→logger.error) in the_on_errormethod ofagent_application.py. This ensures proper logging of errors.Configuration Handling Improvements:
handlers_congif→handlers_config) and improved the logic for initializingauth_handlersinauthorization.py. The updated code ensures thatauth_handlersis always initialized, even when no handlers are provided in the configuration.