Skip to content

Update dev environment installation scripts - #532

Open
Kyle Rohn (kylerohn-msft) wants to merge 5 commits into
mainfrom
users/kylerohn/update-dev-setup-scripts
Open

Update dev environment installation scripts#532
Kyle Rohn (kylerohn-msft) wants to merge 5 commits into
mainfrom
users/kylerohn/update-dev-setup-scripts

Conversation

@kylerohn-msft

Copy link
Copy Markdown
Contributor

This pull request updates the development setup scripts to improve compatibility and ensure all relevant libraries are installed in editable mode. The main changes include making the Python virtual environment setup more robust and adding several hosting libraries to the install list.

Development environment improvements:

  • Updated scripts/dev_setup.sh to check for the presence of the python command and fall back to python3 if necessary, improving compatibility across different systems.
  • Fixed the virtual environment activation command in scripts/dev_setup.sh to use the correct path for Unix-like systems.

Dependency installation updates:

  • Added installation steps for microsoft-agents-hosting-msteams, microsoft-agents-hosting-fastapi, and microsoft-agents-hosting-slack libraries in both scripts/dev_setup.sh and scripts/dev_setup.ps1, ensuring these packages are available in the development environment. [1] [2]

Copilot AI lite review requested due to automatic review settings August 7, 2026 20:08
@kylerohn-msft
Kyle Rohn (kylerohn-msft) requested a review from a team as a code owner August 7, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the developer environment setup scripts to be more portable across systems/shells and to ensure additional hosting libraries are installed in editable mode for local development.

Changes:

  • Updated scripts/dev_setup.sh to select python when available and otherwise fall back to python3, and corrected the Unix virtualenv activation path.
  • Extended both setup scripts to install additional hosting libraries (hosting-msteams, hosting-fastapi, hosting-slack) in editable mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/dev_setup.sh Adds python/python3 selection, fixes Unix venv activation path, and installs additional hosting libs editable.
scripts/dev_setup.ps1 Adds editable installs for additional hosting libs to align Windows setup with the expanded dev environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/dev_setup.sh Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

scripts/dev_setup.sh:10

  • The script prefers python over python3 without validating the interpreter version. On systems where python is Python 2.x or <3.10, this will create an incompatible venv for this repo (which requires Python 3.10+) and subsequent installs will fail in confusing ways.
if command -v python >/dev/null 2>&1
then
    PYTHON=python
elif command -v python3 >/dev/null 2>&1
then

Copilot AI review requested due to automatic review settings August 10, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

scripts/dev_setup.sh:5

  • The script currently prefers python over python3 purely based on PATH presence, which can select Python 2.x on some systems and then fail at -m venv even though python3 is available. It also doesn’t validate the minimum supported Python version (3.10+) and doesn’t stop if venv creation/activation fails, which can lead to subsequent pip install running outside the intended venv.
if command -v python >/dev/null 2>&1
then
    PYTHON=python
elif command -v python3 >/dev/null 2>&1
then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants