Update dev environment installation scripts - #532
Open
Kyle Rohn (kylerohn-msft) wants to merge 5 commits into
Open
Update dev environment installation scripts#532Kyle Rohn (kylerohn-msft) wants to merge 5 commits into
Kyle Rohn (kylerohn-msft) wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the developer environment setup scripts to be more portable across systems/shells and to ensure additional hosting libraries are installed in editable mode for local development.
Changes:
- Updated
scripts/dev_setup.shto selectpythonwhen available and otherwise fall back topython3, and corrected the Unix virtualenv activation path. - Extended both setup scripts to install additional hosting libraries (
hosting-msteams,hosting-fastapi,hosting-slack) in editable mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/dev_setup.sh | Adds python/python3 selection, fixes Unix venv activation path, and installs additional hosting libs editable. |
| scripts/dev_setup.ps1 | Adds editable installs for additional hosting libs to align Windows setup with the expanded dev environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rodrigo Brandão (rodrigobr-msft)
previously approved these changes
Aug 7, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Kyle Rohn (kylerohn-msft)
requested a review
from Rodrigo Brandão (rodrigobr-msft)
August 7, 2026 20:20
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
scripts/dev_setup.sh:10
- The script prefers
pythonoverpython3without validating the interpreter version. On systems wherepythonis Python 2.x or <3.10, this will create an incompatible venv for this repo (which requires Python 3.10+) and subsequent installs will fail in confusing ways.
if command -v python >/dev/null 2>&1
then
PYTHON=python
elif command -v python3 >/dev/null 2>&1
then
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
scripts/dev_setup.sh:5
- The script currently prefers
pythonoverpython3purely based on PATH presence, which can select Python 2.x on some systems and then fail at-m venveven thoughpython3is available. It also doesn’t validate the minimum supported Python version (3.10+) and doesn’t stop if venv creation/activation fails, which can lead to subsequentpip installrunning outside the intended venv.
if command -v python >/dev/null 2>&1
then
PYTHON=python
elif command -v python3 >/dev/null 2>&1
then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the development setup scripts to improve compatibility and ensure all relevant libraries are installed in editable mode. The main changes include making the Python virtual environment setup more robust and adding several hosting libraries to the install list.
Development environment improvements:
scripts/dev_setup.shto check for the presence of thepythoncommand and fall back topython3if necessary, improving compatibility across different systems.scripts/dev_setup.shto use the correct path for Unix-like systems.Dependency installation updates:
microsoft-agents-hosting-msteams,microsoft-agents-hosting-fastapi, andmicrosoft-agents-hosting-slacklibraries in bothscripts/dev_setup.shandscripts/dev_setup.ps1, ensuring these packages are available in the development environment. [1] [2]