Removing uv.lock for internal tool - #531
Merged
Rodrigo Brandão (rodrigobr-msft) merged 3 commits intoAug 7, 2026
Merged
Conversation
Rodrigo Brandão (rodrigobr-msft)
marked this pull request as ready for review
August 7, 2026 18:16
Rodrigo Brandão (rodrigobr-msft)
requested a review
from a team
as a code owner
August 7, 2026 18:16
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
August 7, 2026 18:16
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates authentication/OAuth logging in the Microsoft 365 Agents SDK for Python to avoid emitting sensitive token-related objects/strings in logs, reducing the risk of credential/PII exposure during OAuth and MSAL flows.
Changes:
- Stop logging full
TokenResponseobjects during OAuth flow completion. - Stop logging the
user_assertionvalue when MSAL OBO token acquisition fails (replace with a generic error message).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/_oauth/_oauth_flow.py | Removes logging of TokenResponse details while preserving flow state updates. |
| libraries/microsoft-agents-authentication-msal/microsoft_agents/authentication/msal/msal_auth.py | Removes logging of the user assertion on OBO failure to avoid leaking sensitive assertion tokens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tracyboehrer (tracyboehrer)
approved these changes
Aug 7, 2026
Rodrigo Brandão (rodrigobr-msft)
enabled auto-merge (squash)
August 7, 2026 18:19
Rodrigo Brandão (rodrigobr-msft)
deleted the
users/robrandao/test-dep-bump
branch
August 7, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.