Skip to content

Removing sensitive info logging #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rodrigo Brandão (rodrigobr-msft) merged 1 commit into from
Aug 7, 2026
Merged

Removing sensitive info logging #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...es/microsoft-agents-authentication-msal/microsoft_agents/authentication/msal/msal_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,7 @@ async def acquire_token_on_behalf_of(
)

if "access_token" not in token:
logger.error(
f"Failed to acquire token on behalf of user: {user_assertion}"
)
logger.error(f"Failed to acquire token on behalf of user.")
Comment thread
rodrigobr-msft marked this conversation as resolved.
raise ValueError(
authentication_errors.FailedToAcquireToken.format(str(token))
)
Expand Down
7 changes: 2 additions & 5 deletions libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/_oauth/_oauth_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ async def get_user_token(self, magic_code: str | None = None) -> TokenResponse:
magic_code=magic_code,
)
if token_response:
logger.info("User token obtained successfully: %s", token_response)
logger.info("User token obtained successfully")
self._flow_state.expiration = (
datetime.now(timezone.utc).timestamp() + self._default_flow_duration
)
Expand Down Expand Up @@ -315,10 +315,7 @@ async def continue_flow(self, activity: Activity) -> _FlowResponse:
self._flow_state.expiration = (
datetime.now(timezone.utc).timestamp() + self._default_flow_duration
)
logger.debug(
"OAuth flow completed successfully, got TokenResponse: %s",
token_response,
)
logger.debug("OAuth flow completed successfully, got a token response.")

return _FlowResponse(
flow_state=self._flow_state.model_copy(),
Expand Down
Loading