Skip to content

Adding Activity.name to AppOnTurn span #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rodrigo Brandão (rodrigobr-msft) merged 4 commits into from
Aug 3, 2026
Merged

Adding Activity.name to AppOnTurn span #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd228b3
Adding Activity.name to AppOnTurn span
rodrigobr-msft Aug 3, 2026
b388e80
Undoing unintended testing changes for activity
rodrigobr-msft Aug 3, 2026
5684d3d
Formatting
rodrigobr-msft Aug 3, 2026
812fa68
Merge branch 'main' into users/robrandao/app-spans
rodrigobr-msft Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/app/telemetry/spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ def _get_attributes(self) -> AttributeMap:
attributes.ACTIVITY_TYPE: self._turn_context.activity.type,
attributes.ACTIVITY_ID: self._turn_context.activity.id
or attributes.UNKNOWN,
attributes.ACTIVITY_NAME: self._turn_context.activity.name
or attributes.UNKNOWN,
}

def share(self, route_authorized: bool, route_matched: bool) -> None:
Expand Down
1 change: 1 addition & 0 deletions ...aries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/telemetry/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
ACTIVITY_CHANNEL_ID = "activity.channel_id"
ACTIVITY_ID = "activity.id"
ACTIVITY_COUNT = "activities.count"
ACTIVITY_NAME = "activity.name"
ACTIVITY_TYPE = "activity.type"

AGENTIC_USER_ID = "agentic.user_id"
Expand Down
4 changes: 3 additions & 1 deletion tests/hosting_core/telemetry/test_app_spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ def test_app_on_turn_creates_span(test_exporter):


def test_app_on_turn_span_attributes(test_exporter):
ctx = _make_context(id="act-1")
ctx = _make_context(id="act-1", name="message-received")

with AppOnTurn(ctx):
pass

span = test_exporter.get_finished_spans()[0]
assert span.attributes[attributes.ACTIVITY_TYPE] == "message"
assert span.attributes[attributes.ACTIVITY_ID] == "act-1"
assert span.attributes[attributes.ACTIVITY_NAME] == "message-received"


def test_app_on_turn_span_attributes_missing_id(test_exporter):
Expand All @@ -67,6 +68,7 @@ def test_app_on_turn_span_attributes_missing_id(test_exporter):
span = test_exporter.get_finished_spans()[0]
assert span.attributes[attributes.ACTIVITY_TYPE] == "message"
assert span.attributes[attributes.ACTIVITY_ID] == attributes.UNKNOWN
assert span.attributes[attributes.ACTIVITY_NAME] == attributes.UNKNOWN


def test_app_on_turn_records_turn_metrics(test_exporter, test_metric_reader):
Expand Down
Loading