Skip to content

Small tweaks to HTTP-related adapter code #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rodrigo Brandão (rodrigobr-msft) merged 3 commits into from
Jul 31, 2026
Merged

Small tweaks to HTTP-related adapter code #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f5877e
Addressing issue
rodrigobr-msft Jul 31, 2026
0d70532
Another commit
rodrigobr-msft Jul 31, 2026
174ab14
Merge branch 'main' into users/robrandao/small-fries
rodrigobr-msft Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libraries/microsoft-agents-hosting-aiohttp/microsoft_agents/hosting/aiohttp/cloud_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,5 @@ def _to_aiohttp_response(http_response: HttpResponse) -> Response:
return Response(
status=http_response.status_code,
headers=http_response.headers,
content_type=http_response.content_type,
)
2 changes: 1 addition & 1 deletion libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"InputFile",
"InputFileDownloader",
"Query",
"Route",
"_Route",
Comment thread
rodrigobr-msft marked this conversation as resolved.
"RouteHandler",
"TypingIndicator",
"Citation",
Expand Down
4 changes: 2 additions & 2 deletions ...icrosoft-agents-hosting-core/microsoft_agents/hosting/core/http/_http_request_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

"""Protocol for abstracting HTTP request objects across frameworks."""

from typing import Protocol, Any, Optional
from typing import Protocol, Any, Optional, Mapping


class HttpRequestProtocol(Protocol):
Expand All @@ -19,7 +19,7 @@ def method(self) -> str:
...

@property
def headers(self) -> dict[str, str]:
def headers(self) -> Mapping[str, str]:
"""Request headers."""
...

Expand Down
8 changes: 4 additions & 4 deletions libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/http/_http_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
"""HTTP response abstraction."""

from dataclasses import dataclass
from typing import Any, Optional
from typing import Any


@dataclass
class HttpResponse:
"""Framework-agnostic HTTP response."""

status_code: int
body: Optional[Any] = None
headers: Optional[dict[str, str]] = None
content_type: Optional[str] = "application/json"
body: Any | None = None
headers: dict[str, str] | None = None
content_type: str | None = "application/json"


class HttpResponseFactory:
Expand Down
Loading