-
Notifications
You must be signed in to change notification settings - Fork 86
Type Annotations and API Consistency tweaks #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rodrigo Brandão (rodrigobr-msft)
merged 21 commits into
main
from
users/robrandao/small-potatoes
Jul 22, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fcdcbce
ChannelId channel safe access
rodrigobr-msft ddff5e6
Removing strange annotations
rodrigobr-msft 8bef03a
ChannelAdapter linting fixes
rodrigobr-msft 8bc8ece
ChannelServiceAdapter fixes
rodrigobr-msft ff05e93
ChannelHostProtocol field declarations
rodrigobr-msft 7f92749
ChannelProtocol.post_activity optional type
rodrigobr-msft 6419c29
HttpAdapterBase improvements
rodrigobr-msft a41426d
MessageFactory tweaks
rodrigobr-msft 931857d
RestChannelServiceClientFactory tweaks
rodrigobr-msft e64ddef
Formatting
rodrigobr-msft 6f1889a
Removing None guarding for non-None args
rodrigobr-msft 0d2d49b
Removing None guarding for non-None args
rodrigobr-msft 350cbc6
Potential fix for pull request finding
rodrigobr-msft 09e1ea6
Potential fix for pull request finding
rodrigobr-msft 48a8a78
Fixing tests
rodrigobr-msft c423f5f
Merge branch 'users/robrandao/small-potatoes' of https://github.com/m…
rodrigobr-msft f3a1e12
Adding missing line
rodrigobr-msft 9675a1d
ADdressing PR feedback
rodrigobr-msft 5a4007d
Formatting
rodrigobr-msft 221abbf
Another commit
rodrigobr-msft 3a991cf
Merge branch 'main' into users/robrandao/small-potatoes
rodrigobr-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.