Adding a factory for the 'to' property of SuggestedActions - #370
Merged
Rodrigo Brandão (rodrigobr-msft) merged 1 commit intoApr 16, 2026
Merged
Conversation
Rodrigo Brandão (rodrigobr-msft)
linked an issue
Rodrigo Brandão (rodrigobr-msft)
marked this pull request as ready for review
April 16, 2026 17:11
Rodrigo Brandão (rodrigobr-msft)
requested a review
from a team
as a code owner
April 16, 2026 17:11
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
April 16, 2026 17:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SuggestedActions activity model to avoid a shared mutable default for the to field by switching it to a pydantic.Field(default_factory=list) default, which ensures each model instance gets its own list.
Changes:
- Replace
to: list[...] = []withto: list[...] = Field(default_factory=list). - Add the required
Fieldimport frompydantic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattB (MattB-msft)
approved these changes
Apr 16, 2026
Rodrigo Brandão (rodrigobr-msft)
deleted the
users/robrandao/suggested-actions-list-factory
branch
April 16, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.