Adding fix for incorrectly creating an mcs connector - #360
Merged
Conversation
Axel Suárez (axelsrz)
requested review from
Copilot and
Rodrigo Brandão (rodrigobr-msft)
April 3, 2026 22:15
Rodrigo Brandão (rodrigobr-msft)
approved these changes
Apr 3, 2026
MattB (MattB-msft)
approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts the MCS connector client creation logic so that an MCSConnectorClient is created only when the activity recipient role is connector_user, removing a service_url.startswith("https://pvaruntime") shortcut.
Changes:
- Remove
https://pvaruntimeservice URL prefix check from the MCS connector creation condition. - Restrict MCS connector creation to the
connector_userrecipient role condition only.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Axel Suárez (axelsrz)
enabled auto-merge (squash)
April 3, 2026 22:23
Axel Suárez (axelsrz)
disabled auto-merge
April 3, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the logic for creating a
MCSConnectorClientin therest_channel_service_client_factory.pyfile. Specifically, it removes the check for service URLs starting with"https://pvaruntime", so now the client is only created when the recipient role isconnector_user.