Fix for proactive experimental sample in WC - #217
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type annotation inconsistency in the ConversationAccount class by adding the Optional wrapper to the conversation_type field.
- Updated
conversation_typefield type annotation toOptional[NonEmptyString]to be consistent with its default value ofNone
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Axel Suárez (axelsrz)
enabled auto-merge (squash)
October 31, 2025 15:16
Axel Suárez (axelsrz)
disabled auto-merge
October 31, 2025 15:17
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Oct 31, 2025
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Oct 31, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the
ConversationAccountmodel by changing the type of theconversation_typefield to be optional. This improves the model's flexibility and ensures that the field can be omitted when necessary.