Temporal fix for typing indicator - #209
Merged
Axel Suárez (axelsrz) merged 2 commits intoOct 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves asyncio task cancellation handling in the TypingIndicator class by removing an unnecessary re-raise of CancelledError. The change aligns with Python 3.8+ best practices where catching and not re-raising CancelledError indicates that cancellation is expected and properly handled.
- Removed
raisestatement fromCancelledErrorhandler in_typing_loopmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tracyboehrer (tracyboehrer)
approved these changes
Oct 28, 2025
Axel Suárez (axelsrz)
deleted the
users/axsuarez/typing-indicator-temporal-fix
branch
October 28, 2025 18:49
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Oct 28, 2025
Axel Suárez (axelsrz)
added a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the typing indicator loop in
typing_indicator.py. The change removes the re-raising of theasyncio.CancelledErrorexception after logging its cancellation, which prevents the exception from propagating further.asyncio.CancelledErroris now only logged and not re-raised in the_typing_loopmethod oftyping_indicator.py, simplifying error handling.