Refactor locking mechanism to use asyncio.Lock for asynchronous container initialization - #185
Merged
Chris Mullins (cleemullins) merged 1 commit intoOct 21, 2025
Conversation
…iner initialization
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the locking mechanism in CosmosDBStorage from threading.Lock to asyncio.Lock to properly support asynchronous container initialization, addressing issue #184.
Key Changes:
- Replaced threading.Lock with asyncio.Lock for thread-safe asynchronous operations
- Updated lock acquisition syntax from
withtoasync withto match asyncio patterns - Updated inline comment to reflect asynchronous context
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Rodrigo Brandão (rodrigobr-msft)
approved these changes
Oct 21, 2025
Chris Mullins (cleemullins)
deleted the
users/cleemullins/CosmosDbThreading
branch
October 21, 2025 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184