Fixing docstrings - #105
Merged
Axel Suárez (axelsrz) merged 4 commits intoAug 27, 2025
Merged
Conversation
Axel Suárez (axelsrz)
requested a review
from Rodrigo Brandão (rodrigobr-msft)
August 27, 2025 22:15
Rodrigo Brandão (rodrigobr-msft)
approved these changes
Aug 27, 2025
Rodrigo Brandão (rodrigobr-msft)
pushed a commit
that referenced
this pull request
Sep 16, 2025
* Fixing docstrings * fixing import
Rodrigo Brandão (rodrigobr-msft)
pushed a commit
that referenced
this pull request
Sep 17, 2025
* Fixing docstrings * fixing import
Rodrigo Brandão (rodrigobr-msft)
added a commit
that referenced
this pull request
Sep 17, 2025
Chris Mullins (cleemullins)
deleted the
users/axsuarez/typing-docstrings-fix
branch
October 2, 2025 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates type annotations across multiple model classes in the
microsoft_agents/activitypackage. The main change is replacing references to types in the~microsoft_agents.protocols.modelsnamespace with references to types in the~microsoft_agents.activitynamespace, ensuring consistency and proper linkage within the codebase.Type annotation updates for activity models:
Activity,ChannelAccount,ConversationAccount,ConversationMembers,ConversationParameters,ConversationReference,ConversationsResult,Mention, and related classes to use types from~microsoft_agents.activityinstead of~microsoft_agents.protocols.models[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11].Type annotation updates for card models:
AnimationCard,AudioCard,BasicCard,HeroCard,MediaCard,CardAction, andCardImageto use types from~microsoft_agents.activity[1] [2] [3] [4] [5] [6] [7].Type annotation updates for error and reply models:
AttachmentInfo,Error,ErrorResponse, andExpectedRepliesto use types from~microsoft_agents.activity[1] [2] [3] [4].