Skip to content

feat(client): native HTTP/1.1 client replacing may_http - #1

Merged
casibbald merged 1 commit into
integration/microscaler-forkfrom
feat/native-http-client
Jul 9, 2026
Merged

feat(client): native HTTP/1.1 client replacing may_http#1
casibbald merged 1 commit into
integration/microscaler-forkfrom
feat/native-http-client

Conversation

@casibbald

Copy link
Copy Markdown

Add feature-gated may_minihttp::client with HttpClient, Request, and Response API-compatible with may_http::client. DELETE/PUT/PATCH write_head is safe (no Drop panic). Enables BRRTRouter to drop the abandoned may_http crate without waiting on upstream.

Add feature-gated may_minihttp::client with HttpClient, Request, and
Response API-compatible with may_http::client. DELETE/PUT/PATCH write_head
is safe (no Drop panic). Enables BRRTRouter to drop the abandoned may_http
crate without waiting on upstream.
@casibbald
casibbald force-pushed the feat/native-http-client branch from fd281a6 to 2789db9 Compare July 9, 2026 20:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a native, feature-gated HTTP/1.1 client module (client) to may_minihttp, eliminating the dependency on the abandoned may_http crate. The implementation includes connection management via HttpClient, buffered I/O handling with BufferIo, request and response body streaming using BodyReader and BodyWriter, and outgoing/incoming message models (Request and Response). Additionally, comprehensive documentation, design documents, and epic stories are added to guide the development and integration. As there are no review comments provided, I have no further feedback to offer.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@casibbald
casibbald merged commit 3f8cc92 into integration/microscaler-fork Jul 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant