Feature/standardize testing and ci - #166
Merged
Diego Barajas (barajas-d) merged 6 commits intoAug 11, 2026
Merged
Conversation
order.rb: fix wrong keyword argument params: -> filters: in search disbursement_refund.rb: add missing data: keyword to _post call Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Replace all integration tests (requiring live ACCESS_TOKEN) with mock-based unit tests using a MockHttpClient subclass. Add BaseClientTest base class, JSON fixtures directory, and rewrite all 21 domain test files covering every public method. Also adds vendor/ to .gitignore to prevent accidental commits. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Re-enable unit tests in CI (now mock-based, no ACCESS_TOKEN needed) - Add Ruby version matrix: 3.2, 3.3, 3.4 - Switch from container to ruby/setup-ruby with bundler-cache - Add bundler-audit for dependency scanning - Add dependency-review-action on pull requests - Standardize CD trigger to release:published Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
ruby/setup-ruby is not on the enterprise allowlist. Use Docker container: ruby:X.X directly — same approach as the original CI but with the 3.2/3.3/3.4 matrix preserved. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
gemspec declares required_ruby_version >= 3.3.0 so 3.2 is incompatible. Matrix is now 3.3 and 3.4. Add git safe.directory config to fix ownership error when running bundle inside a Docker container job. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Docker container jobs fail on bundle install if git safe.directory is not set first. Move the config step before dependency install. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Diego Barajas (barajas-d)
approved these changes
Aug 11, 2026
Diego Barajas (barajas-d)
deleted the
feature/standardize-testing-and-ci
branch
August 11, 2026 21:44
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.