workspace: hoist shared deps and lint policy to workspace - #177
Open
meawoppl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements maintainability bump #3.
What
[workspace.dependencies]— hoisted the deps shared by both crates (serde,serde_json,thiserror,tokio,log,which, devenv_logger). Members now reference them viadep = { workspace = true }, keeping versions in lockstep. Crate-specific deps (chrono,uuid,anyhow,base64,jsonschema) stay local.[workspace.lints]— added a shared lint policy (unsafe_code = "forbid"; nounsafeexists in either crate) with both crates opting in via[lints] workspace = true. Single place to evolve lint policy going forward.Why
The manifests had drifted: claude declared
tokio 1.47.1/log 0.4.27while codex declaredtokio 1.49.0/log 0.4.29(andenv_logger0.11.8 vs 0.11.9). The resolver already unified these in the lockfile, so this is manifest hygiene — but it stops the declared minimums from diverging further and gives one source of truth.Cargo.lockis unchanged (versions were already unified by the resolver).Verification
cargo build --workspace --all-features— cleancargo clippy --workspace --all-targets -- -D warnings(the CI gate) — clean, incl. types-only feature combocargo test --workspace— all passNo version bump (internal build change, nothing to publish).