fix: decode U+10FFFF instead of replacing it with U+FFFD#103
Open
greymoth-jp wants to merge 1 commit into
Open
fix: decode U+10FFFF instead of replacing it with U+FFFD#103greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodereplaces the numeric reference(and) with U+FFFD, but U+10FFFF is a valid Unicode scalar value andencodeemits it just fine:So a string containing the highest code point does not survive a round trip through
encode/decode, even thoughString.fromCodePoint(0x10ffff)is valid in JS (only0x110000and above throw).The cause is an off-by-one in the bounds check inside
getDecodedEntity:The WHATWG numeric character reference rules only substitute U+FFFD when the referenced value is greater than 0x10FFFF, so the comparison should be
>. U+10FFFE and every code point below it already decode correctly; only the maximum was being caught by the>=.This changes the check to
>and adds a test covering,, the encode/decode round trip, and that�(past the Unicode range) still maps to U+FFFD.