Changes to Dotcom translation workflow#3307
Open
lilybarrett wants to merge 7 commits into
Open
Conversation
More WIP More changes Update ReadMe
lilybarrett
force-pushed
the
lb/translation_task_changes
branch
from
076bc9b to
a47600b
Compare
joshlarson
reviewed
Jul 1, 2026
joshlarson
reviewed
Jul 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lilybarrett
added
Not Ready for Translation
lilybarrett
force-pushed
the
lb/translation_task_changes
branch
from
2d5c9fa to
6d8bdc0
Compare
arkadyan
reviewed
Jul 6, 2026
lilybarrett
force-pushed
the
lb/translation_task_changes
branch
from
de32fae to
d558ce8
Compare
Code cleanup WIP Revert changes to cldr See if this works for CI Check on every file change Ensure CI check happens in the proper place
Update ReadMe More ReadMe updates tweak: Commit `fr.json` file Commit updated .pot file to see if this passes the CI check New mix command for local gettext checks, updates to files
…sk_changes (#3317) * Translations updated for PR#3307 on es-LA locale * Translations updated for PR#3307 on ht-HT locale * Translations updated for PR#3307 on zh-TW locale * Translations updated for PR#3307 on pt-BR locale * Translations updated for PR#3307 on vi-VN locale * Translations updated for PR#3307 on zh-CN locale --------- Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com> Update ReadMe Does this work better in CI? Trying something else Try to get more verbose CI output
lilybarrett
force-pushed
the
lb/translation_task_changes
branch
2 times, most recently
from
15b60dc to
aa15fdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
We realized that Dotcom's custom translation task is making it so a single string,
All clear, captain!was the only thing getting translated from English. This changes the code so we can properly update our.pofiles for translations going forward.Asana Ticket: Implement: Fix workflows/Add CI checks/Update ReadMe
Implementation
translator.ymlandtranslate.exterminologiesgettextpluralization logicmix localize, that should be run manually to update.pofiles before making PRs.pofiles have been properly updated.pofile for English phrasesScreenshots
How to test
mix localizelocally to update your.pofiles/_flagsand turn on the Smartling flag