feat(listen-together): listen in sync with friends in Metrolist-compatible rooms - #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listen Together: create a room, share an 8-character code, and everyone hears the same track at the same position.
The rooms are the ones Metrolist already uses, so a SimpMusic client and a Metrolist client can sit in the same room. The protocol work is in the
coresubmodule — see maxrave-dev/core#28, which must merge first.What a user sees
Screen
Built as a page rather than a stack of identical cards: two columns once the window is wide enough for two real ones, with the room code as the one deliberately outsized element — it is the thing people read aloud. Connection state is a single line, members are a divided list, and leaving/settings are quiet Material buttons at the end.
Everything resolves through
MaterialTheme.colorScheme, so it is correct on the light theme too. The screens the glass treatment was borrowed from (Album, Playlist, Artist, Analytics) all sit insideForceDarkContent, so their white default tint is always over a dark page; this one follows the theme and has to pass its own.Architecture
composeAppnever sees the protocol. It talks toListenTogetherRepositoryindomain;ListenTogetherRepositoryImplindatais the only place that knows the service module exists.Notes
docs/is removed in this branch.version-nameis bumped to2.0.0-alpha, which the Windows MSI target rejects —desktopApp/build.gradle.ktsonly strips a-hfsuffix today, so it needssubstringBefore("-")before a desktop release build will configure.Testing
Protocol round-trip and handshake tests live in
core. Playback sync was exercised with two live clients againstwss://metroserverx.meowery.eu/ws.