Skip to content

Update squizlabs/php_codesniffer to version 4 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-antipin merged 1 commit into from
Jul 15, 2026
Merged

Update squizlabs/php_codesniffer to version 4 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions AntipinCS/Sniffs/Classes/PropertyTypeDeclarationSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

class PropertyTypeDeclarationSniff extends AbstractVariableSniff
{
protected function processMemberVar(File $phpcsFile, $stackPtr): void
protected function processMemberVar(File $phpcsFile, int $stackPtr): void
{
$tokens = $phpcsFile->getTokens();

Expand Down Expand Up @@ -66,7 +66,7 @@ protected function processMemberVar(File $phpcsFile, $stackPtr): void
*
* @return void
*/
protected function processVariable(File $phpcsFile, $stackPtr): void
protected function processVariable(File $phpcsFile, int $stackPtr): void
{
/*
We don't care about normal variables.
Expand All @@ -81,7 +81,7 @@ protected function processVariable(File $phpcsFile, $stackPtr): void
*
* @return void
*/
protected function processVariableInString(File $phpcsFile, $stackPtr): void
protected function processVariableInString(File $phpcsFile, int $stackPtr): void
{
/*
We don't care about normal variables.
Expand Down
2 changes: 1 addition & 1 deletion AntipinCS/Sniffs/Functions/ParameterTypeDeclarationSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function register(): array
];
}

public function process(File $phpcsFile, $stackPtr): void
public function process(File $phpcsFile, int $stackPtr): void
{
$tokens = $phpcsFile->getTokens();
$token = $tokens[$stackPtr];
Expand Down
5 changes: 3 additions & 2 deletions AntipinCS/Sniffs/Functions/ReturnTypeDeclarationSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function register(): array
];
}

public function process(File $phpcsFile, $stackPtr): void
public function process(File $phpcsFile, int $stackPtr): void
{
$tokens = $phpcsFile->getTokens();
$token = $tokens[$stackPtr];
Expand All @@ -36,9 +36,10 @@ public function process(File $phpcsFile, $stackPtr): void
);
return;
}
static $skipTypes = ['T_CLOSURE' => true, 'T_FN' => true];
static $skipMethods = ['__construct' => true, '__destruct' => true];
if (
$token['code'] !== 311
!isset($skipTypes[$token['type']])
&& ($methodName = $phpcsFile->getDeclarationName($stackPtr)) !== null
&& isset($skipMethods[$methodName])
) {
Expand Down
2 changes: 1 addition & 1 deletion AntipinCS/Tests/Functions/ParameterTypeDeclarationUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ final class ParameterTypeDeclarationUnitTest extends AbstractSniffUnitTest
*
* @return string[]
*/
protected function getTestFiles($testFileBase): array
protected function getTestFiles(string $testFileBase): array
{
return array_map(static fn (int $i): string => $testFileBase . $i . '.inc', range(1, 4));
}
Expand Down
2 changes: 1 addition & 1 deletion AntipinCS/Tests/Functions/ReturnTypeDeclarationUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class ReturnTypeDeclarationUnitTest extends AbstractSniffUnitTest
*
* @return string[]
*/
protected function getTestFiles($testFileBase): array
protected function getTestFiles(string $testFileBase): array
{
return array_map(static fn (int $i): string => $testFileBase . $i . '.inc', range(1, 2));
}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"license": "Unlicense",
"require": {
"php": ">=8.4",
"squizlabs/php_codesniffer": "^3.13",
"squizlabs/php_codesniffer": "^4",
"dealerdirect/phpcodesniffer-composer-installer": "^1.2"
},
"require-dev": {
Expand Down
Loading