Document removal of deprecated DateTime dialog fields (MM-68396) - #1519
Document removal of deprecated DateTime dialog fields (MM-68396)#1519sbishel wants to merge 2 commits into
Conversation
|
Newest code from mattermost has been published to preview environment for Git SHA 2548a30 |
📝 WalkthroughWalkthroughUpdates interactive dialog documentation to remove deprecated top-level date and datetime fields, direct integrations to nested ChangesInteractive dialog configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@site/content/integrate/plugins/interactive-dialogs/_index.md`:
- Around line 581-583: Update the breaking-change note so `time_interval` is
described as a removed top-level field only for `datetime` elements, while
keeping `min_date` and `max_date` scoped to both `date` and `datetime` elements.
Preserve the existing guidance to send `time_interval` under `datetime_config`
and rename `allow_manual_time_entry` to `manual_time_entry`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fde28efa-de62-4645-b157-18d4b053ff1d
📒 Files selected for processing (1)
site/content/integrate/plugins/interactive-dialogs/_index.md
|
Newest code from mattermost has been published to preview environment for Git SHA 41d4de2 |
|
|
||
| **Backward compatibility (new in 11.8):** The top-level `min_date`, `max_date`, and `time_interval` fields on `date` and `datetime` elements are still accepted for existing integrations, but are deprecated in favor of `datetime_config`. When both are provided on the same element, values inside `datetime_config` take precedence over the legacy top-level values. | ||
| {{<note "DateTime field breaking change (server version 12.0):">}} | ||
| The top-level `min_date`, `max_date`, and `time_interval` fields on `date`/`datetime` elements, and the `datetime_config.allow_manual_time_entry` field, have been removed. Integrations must send these values under `datetime_config` (using `manual_time_entry` instead of `allow_manual_time_entry`) or they will be silently ignored. |
There was a problem hiding this comment.
| The top-level `min_date`, `max_date`, and `time_interval` fields on `date`/`datetime` elements, and the `datetime_config.allow_manual_time_entry` field, have been removed. Integrations must send these values under `datetime_config` (using `manual_time_entry` instead of `allow_manual_time_entry`) or they will be silently ignored. | |
| The top-level `min_date`, `max_date`, and `time_interval` fields on `date`/`datetime` elements, and the `datetime_config.allow_manual_time_entry` field, have been removed with Mattermost v12. Integrations must send these values under `datetime_config` (using `manual_time_entry` instead of `allow_manual_time_entry`) or they will be silently ignored. |
Summary
min_date/max_date(top-level ondateelements),min_date/max_date/time_interval(top-level ondatetimeelements), anddatetime_config.allow_manual_time_entryrows from the Interactive Dialog docs, since these fields have been removed server-side in server version 12.0.datetime_configobject section explaining that these values must now be sent underdatetime_config(usingmanual_time_entryinstead ofallow_manual_time_entry), and that un-migrated payloads will have them silently ignored.Related
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-68396