feat: render html in quick preview with local assets - #130
Merged
mattenarle10 merged 1 commit intoAug 8, 2026
Conversation
.html/.htm files previously previewed as raw source. Classify them as a new "html" preview kind and render in a sandboxed iframe (allow-scripts) with a <base> pointing at the file's directory, so relative images/css/ scripts resolve through the asset protocol (enabled with scope **, matching the existing fs read scope). "open as text" stays available for viewing the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Quick preview now renders
.html/.htmfiles instead of showing raw source:htmlpreview kind insrc/lib/preview.ts(moved out of the text bucket)sandbox="allow-scripts"— scripts run in an opaque origin, no same-origin/local-file access)htmlDocWithBase()injects a<base>pointing at the file's directory viaconvertFileSrc(), so relative images/css/scripts resolvescope: ["**"], same surface as the existingfs:allow-read-file **permission) +protocol-assetcargo featuresecurity notes
verification
bun test— 73 pass (incl. newhtmlDocWithBasecases)tsc --noEmitcleancargo checkclean