Skip to content

update tests for room v12 - #1429

Merged
anoadragon453 merged 2 commits into
matrix-org:developfrom
famedly:tt/room-v12
Aug 3, 2026
Merged

update tests for room v12#1429
anoadragon453 merged 2 commits into
matrix-org:developfrom
famedly:tt/room-v12

Conversation

@FrenchGithubUser

@FrenchGithubUser FrenchGithubUser commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Update tests to pass with room v12

Depends on: element-hq/synapse#19898

TODO: before merging, revert the changes in pipeline.yml Done in 9b177e9.

@FrenchGithubUser
FrenchGithubUser marked this pull request as ready for review July 1, 2026 14:39
@FrenchGithubUser
FrenchGithubUser requested a review from a team as a code owner July 1, 2026 14:39
@FrenchGithubUser FrenchGithubUser changed the title wip: update tests for room v12 update tests for room v12 Jul 8, 2026
@anoadragon453
anoadragon453 requested a review from Copilot July 23, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates SyTest’s federation helpers and test expectations to accommodate Matrix room v12 semantics (hash-based room IDs, m.room.create lacking room_id, and creator power-level changes), and sets the default test room version to 12 to exercise these paths by default.

Changes:

  • Add room-version helpers and apply v12-specific logic for room IDs and auth_events handling in federation event construction.
  • Update multiple federation tests to build auth_events correctly for v12 and adjust assertions for v12 create events / creator power levels.
  • Temporarily adjust CI pipeline to pull a Synapse branch with room v12 support (noted as TODO to revert before merging).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/50federation/52soft-fail.pl Use auth_event_refs when constructing auth_events so v12 create events aren’t referenced.
tests/50federation/36state.pl Use auth_event_refs for rejected-event construction to keep v12 auth_events valid.
tests/50federation/33room-get-missing-events.pl Use auth_event_refs for membership event auth chain construction under v12.
tests/50federation/31room-send.pl Use auth_event_refs for auth chain construction under v12.
tests/50federation/30room-join.pl Relax room_id requirement to allow v12 create events without room_id (and adjust validation logic).
tests/31sync/09archived.pl Serialize room creation to avoid possible v12 room-ID collisions from identical create events.
tests/30rooms/60version_upgrade.pl Pin specific tests to room v11 to continue testing pre-v12 upgrade behaviors.
tests/30rooms/01state.pl Adjust creator power-level expectations depending on whether the room is v12+.
run-tests.pl Default $TEST_ROOM_VERSION to 12.
lib/SyTest/Federation/Room.pm Add auth_event_refs; implement v12 room-id derivation from create event; omit create from auth_events in v12.
lib/SyTest/Federation/Datastore.pm Allow v12 create events without room_id; factor ref decoding into _event_ref_ids for v12 compatibility.
lib/SyTest/Federation/Client.pm Advertise support for room version 12.
lib/Protocol/Matrix.pm Add room_version_is_11_plus / room_version_is_12_plus helpers and use them in redaction/version logic.
.github/workflows/pipeline.yml Temporarily hardcode Synapse download source to a room-v12 branch (TODO says to revert).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pipeline.yml Outdated
Comment thread tests/50federation/30room-join.pl Outdated

@anoadragon453 anoadragon453 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this one. Just a few small things below.

Comment thread tests/30rooms/60version_upgrade.pl Outdated
Comment thread tests/31sync/09archived.pl Outdated
Comment thread .github/workflows/pipeline.yml Outdated
Comment thread tests/50federation/30room-join.pl Outdated
@anoadragon453

Copy link
Copy Markdown
Member

The associated Synapse PR has now been merged.

@anoadragon453 anoadragon453 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with this one! This now LGTM.

@anoadragon453
anoadragon453 merged commit d87ce84 into matrix-org:develop Aug 3, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants