update tests for room v12 - #1429
Merged
Merged
Conversation
FrenchGithubUser
force-pushed
the
tt/room-v12
branch
from
June 30, 2026 10:17
8ddb1e9 to
528531d
Compare
3 tasks
FrenchGithubUser
force-pushed
the
tt/room-v12
branch
3 times, most recently
from
June 30, 2026 15:59
ea862ec to
e7f71a6
Compare
FrenchGithubUser
force-pushed
the
tt/room-v12
branch
from
July 1, 2026 12:42
e7f71a6 to
9222ad9
Compare
FrenchGithubUser
marked this pull request as ready for review
July 1, 2026 14:39
There was a problem hiding this comment.
Pull request overview
Updates SyTest’s federation helpers and test expectations to accommodate Matrix room v12 semantics (hash-based room IDs, m.room.create lacking room_id, and creator power-level changes), and sets the default test room version to 12 to exercise these paths by default.
Changes:
- Add room-version helpers and apply v12-specific logic for room IDs and
auth_eventshandling in federation event construction. - Update multiple federation tests to build
auth_eventscorrectly for v12 and adjust assertions for v12 create events / creator power levels. - Temporarily adjust CI pipeline to pull a Synapse branch with room v12 support (noted as TODO to revert before merging).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/50federation/52soft-fail.pl | Use auth_event_refs when constructing auth_events so v12 create events aren’t referenced. |
| tests/50federation/36state.pl | Use auth_event_refs for rejected-event construction to keep v12 auth_events valid. |
| tests/50federation/33room-get-missing-events.pl | Use auth_event_refs for membership event auth chain construction under v12. |
| tests/50federation/31room-send.pl | Use auth_event_refs for auth chain construction under v12. |
| tests/50federation/30room-join.pl | Relax room_id requirement to allow v12 create events without room_id (and adjust validation logic). |
| tests/31sync/09archived.pl | Serialize room creation to avoid possible v12 room-ID collisions from identical create events. |
| tests/30rooms/60version_upgrade.pl | Pin specific tests to room v11 to continue testing pre-v12 upgrade behaviors. |
| tests/30rooms/01state.pl | Adjust creator power-level expectations depending on whether the room is v12+. |
| run-tests.pl | Default $TEST_ROOM_VERSION to 12. |
| lib/SyTest/Federation/Room.pm | Add auth_event_refs; implement v12 room-id derivation from create event; omit create from auth_events in v12. |
| lib/SyTest/Federation/Datastore.pm | Allow v12 create events without room_id; factor ref decoding into _event_ref_ids for v12 compatibility. |
| lib/SyTest/Federation/Client.pm | Advertise support for room version 12. |
| lib/Protocol/Matrix.pm | Add room_version_is_11_plus / room_version_is_12_plus helpers and use them in redaction/version logic. |
| .github/workflows/pipeline.yml | Temporarily hardcode Synapse download source to a room-v12 branch (TODO says to revert). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anoadragon453
requested changes
Jul 23, 2026
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Thanks for your patience on this one. Just a few small things below.
Member
|
The associated Synapse PR has now been merged. |
anoadragon453
approved these changes
Aug 3, 2026
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Thanks for sticking with this one! This now LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to pass with room v12
Depends on: element-hq/synapse#19898
TODO: before merging, revert the changes inDone in 9b177e9.pipeline.yml