Sinkhorn loss implementatin#809
Open
guglielmopadula wants to merge 5 commits into
Open
Conversation
GiovanniCanali
added
enhancement
GiovanniCanali
requested changes
Jun 18, 2026
GiovanniCanali
left a comment
GiovanniCanali
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @guglielmopadula for the valuable contribution. The code and overall logic look good, only a few minor comments need to be addressed before merging.
| log_b - torch.logsumexp((f.unsqueeze(1) - C) / self.eps, dim=0) | ||
| ) | ||
|
|
||
| loss = (a * f).sum() + (b * g).sum() |
Collaborator
There was a problem hiding this comment.
If I understand correctly, this loss can take negative values. Please confirm whether this is expected behavior; otherwise, adjust the implementation accordingly.
Member
Author
There was a problem hiding this comment.
The loss can indeed take negative values.
Member
Author
|
I have fixed the code according to instructions. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #808 by adding a Sinkhorn loss implementation (the loss init file is modified, a new class, SinkhornLoss, is created along with the necessary tests).
Checklist