Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions app/test_split_integer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,25 @@


def test_sum_of_the_parts_should_be_equal_to_value() -> None:
pass
result = split_integer(11, 3)
assert sum(result) == 11
Comment on lines +5 to +6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: unnecessary result variable. Inline the function call: assert sum(split_integer(11, 3)) == 11



def test_should_split_into_equal_parts_when_value_divisible_by_parts() -> None:
pass
result = split_integer(12, 3)
assert result == [4, 4, 4]
Comment on lines +10 to +11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates both checklist items: #1 - unnecessary result variable, and #2 - asserts on sum(result) instead of comparing the actual result array.



def test_should_return_part_equals_to_value_when_split_into_one_part() -> None:
pass
result = split_integer(7, 1)
assert result == [7]
Comment on lines +15 to +16

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: unnecessary result variable. Inline: assert split_integer(7, 1) == [7]



def test_parts_should_be_sorted_when_they_are_not_equal() -> None:
pass
result = split_integer(11, 3)
assert result == [3, 4, 4]
Comment on lines +20 to +21

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: unnecessary result variable. Inline: assert split_integer(11, 3) == [3, 4, 4]



def test_should_add_zeros_when_value_is_less_than_number_of_parts() -> None:
pass
result = split_integer(3, 5)
assert result == [0, 0, 1, 1, 1]
Comment on lines +25 to +26

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: unnecessary result variable. Inline: assert split_integer(3, 5) == [0, 0, 1, 1, 1]

Loading