Test split integer#2154
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is an educational approval to support your learning progress.
What's working well: Your tests successfully verify the core functionality — split results sum correctly, and parts are properly sorted. Test naming is descriptive and file structure follows requirements.
Areas to improve:
- Two tests create unnecessary variables before assertion (e.g.,
result = split_integer(...)followed byassert result == ...). Per [CHECKLIST ITEM #1], you can compare directly:assert split_integer(value, n) == expected_result - A key requirement is missing: the description states "the difference between max and min should be <= 1", but no test validates this constraint — consider adding a test like
test_max_min_difference_should_be_one_or_less
These are focused improvements for a solid foundation. You're on the right track!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| def test_sum_of_the_parts_should_be_equal_to_value() -> None: | ||
| pass | ||
| result = split_integer(10, 2) |
There was a problem hiding this comment.
This creates an unnecessary variable. Per checklist item #1, compare the result directly in assert for simple tests.
| def test_parts_should_be_sorted_when_they_are_not_equal() -> None: | ||
| pass | ||
| result = split_integer(17, 4) |
There was a problem hiding this comment.
This creates an unnecessary variable. Per checklist item #1, compare the result directly in assert for simple tests.
|
|
||
| def test_parts_should_be_sorted_when_they_are_not_equal() -> None: | ||
| pass | ||
| result = split_integer(17, 4) | ||
| assert result == sorted(result) |
There was a problem hiding this comment.
The description explicitly requires that 'the difference between the max and min number in the array should be <= 1'. No test validates this constraint. Consider adding a test like test_max_min_difference_should_not_exceed_one.
2 participants
No description provided.