Skip to content

test: add unit tests for split_integer function #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Somewellich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: add unit tests for split_integer function #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions app/test_split_integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,25 @@


def test_sum_of_the_parts_should_be_equal_to_value() -> None:
pass
result = split_integer(32, 6)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: Don't create unnecessary variables for simple tests because you assign result = split_integer(32, 6) and then only use it in the assert. For simple equality or property checks, compare split_integer(32, 6) directly in the assert.

assert sum(result) == 32


def test_should_split_into_equal_parts_when_value_divisible_by_parts() -> None:
pass
result = split_integer(6, 2)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test also violates checklist item #1: Don't create unnecessary variables for simple tests by introducing result when it’s only used once in the following assert. Consider writing assert split_integer(6, 2) == [3, 3] directly.

assert result == [3, 3]


def test_should_return_part_equals_to_value_when_split_into_one_part() -> None:
pass
result = split_integer(8, 1)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again you introduce an unnecessary result variable, which matches the "Bad example" pattern in checklist item #1. The test can be simplified to assert split_integer(8, 1) == [8].

assert result == [8]


def test_parts_should_be_sorted_when_they_are_not_equal() -> None:
pass
result = split_integer(17, 4)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line follows the same unnecessary-variable pattern as the checklist’s "Bad example". Checklist item #1 asks to avoid such temporary variables in simple tests; you can assert directly on split_integer(17, 4).

assert result == [4, 4, 4, 5]


def test_should_add_zeros_when_value_is_less_than_number_of_parts() -> None:
pass
result = split_integer(2, 5)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test also uses an unnecessary result variable, violating checklist item #1. For simple tests, avoid this pattern and assert directly on the function call.

assert result == [0, 0, 0, 1, 1]
Loading