Skip to content

Solution #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ilya-Tayanovsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/test_split_integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,22 @@


def test_sum_of_the_parts_should_be_equal_to_value() -> None:
pass
result = split_integer(19, 4)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the "Bad example" pattern from checklist item #1: you assign result = split_integer(19, 4) and then only use it once in the next line. For simple tests you should inline the function call in the assertion instead of creating an unnecessary variable.

assert sum(result) == 19


def test_should_split_into_equal_parts_when_value_divisible_by_parts() -> None:
pass
assert split_integer(6, 2) == [3, 3]


def test_should_return_part_equals_to_value_when_split_into_one_part() -> None:
pass
assert split_integer(8, 1) == [8]


def test_parts_should_be_sorted_when_they_are_not_equal() -> None:
pass
result = split_integer(19, 4)

@mateacademy-ai-mentor mateacademy-ai-mentor Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also violates checklist item #1: "Don't create unnecessary variables for simple tests". Here result is only used once to check sorting, so you should call split_integer(19, 4) directly inside the assert statement (e.g. compare split_integer(19, 4) to sorted(...)).

assert result == sorted(result)


def test_should_add_zeros_when_value_is_less_than_number_of_parts() -> None:
pass
assert split_integer(4, 6) == [0, 0, 1, 1, 1, 1]
Loading