Skip to content

[pull] release/3.0.0-beta2 from isaac-sim:release/3.0.0-beta2 - #22

Merged
pull[bot] merged 1 commit into
mataylor-nvidia:release/3.0.0-beta2from
isaac-sim:release/3.0.0-beta2
Jul 31, 2026
Merged

[pull] release/3.0.0-beta2 from isaac-sim:release/3.0.0-beta2#22
pull[bot] merged 1 commit into
mataylor-nvidia:release/3.0.0-beta2from
isaac-sim:release/3.0.0-beta2

Conversation

@pull

@pull pull Bot commented Jul 31, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

## 1. Summary

- Adds an `image` dimension to the nightly publish matrix so
`docker/Dockerfile.kitless` is built and pushed alongside
`docker/Dockerfile.base`.
- Both images share the `isaaclab_image_name` repository and are
distinguished by a `-kitless` tag suffix, so no registry-side
provisioning is required.
- Base image tags, platforms and build arguments are unchanged, verified
by simulating every branch x image combination.
- One file, +30 / -8.

## 2. Background

The kit-less container landed on `develop` in
#6355 — "[Newton] Add a
kitless training container". That PR builds and validates the image in
`kitless-docker.yml`, but publishing is owned by this workflow, which
only ever built `Dockerfile.base`. As a result no kit-less image reaches
the registry.

Scheduled workflows run only from the default branch, which is
`release/3.0.0-beta2` — every nightly since 2026-07-26 has run from it —
so this change belongs here rather than on `main`.

## 3. Design

- `CRON_BRANCHES` is unchanged; the matrix cross-product is branch x
image.
- The kit-less leg pins `linux/amd64`. `ubuntu:24.04` is multi-arch and
`ovrtx` ships an aarch64 wheel, but no arm64 GPU runner validates that
build, so the published manifest is limited to the architecture CI
exercises.
- A Dockerfile-existence guard lets a branch cut before an image was
introduced skip it instead of failing the run. This is required because
`Dockerfile.kitless` does not exist on this branch or on older releases.
- `concurrency.group` gains the image key. Without it the two legs share
a group under `cancel-in-progress: true` and cancel each other.
- `DOCKER_USER_HOME_ARG` moves into the matrix (`/root` for base,
`/home/isaaclab` for kit-less) so the published image matches its
Compose profile. The `ISAACSIM_*` arguments stay inline because
`strategy.matrix` cannot reference the `steps` context that supplies
them.

## 4. Test plan

- [x] Simulated the build step across `develop`, `release/3.0.0-beta2`
and `main` x both images with a stubbed `docker`; confirmed tags,
platforms, Dockerfile and `DOCKER_USER_HOME_ARG` per leg, and that base
output is identical to today.
- [x] Verified `main` is still skipped by both legs, as before.
- [x] `uv run isaaclab -f` on all files.
- [ ] First real publish is the next nightly run after merge.
@pull pull Bot locked and limited conversation to collaborators Jul 31, 2026
@pull pull Bot added the ⤵️ pull label Jul 31, 2026
@pull
pull Bot merged commit 99e7bc1 into mataylor-nvidia:release/3.0.0-beta2 Jul 31, 2026
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant