AH subprocess Phase 3: bound terminal worker journal retention

[MadMaxMangos]

Summary

• Add periodic bounded retention for terminal ah_worker_journal rows.
• Prune COMMITTED rows by created_time and APPLIED rows by resolved_time.
• Retain an APPLIED resolution while custody_ledger still contains its resolve:<uuid> idempotency marker.
• Drain at most 100 rows per terminal state per service-loop pass, allowing IPC and heartbeat processing between batches.
• Start one bounded retention pass at worker startup, then use the configured cadence.
• Stamp direct APPLIED transitions from wall time so retention does not depend on the first IPC_GAMETIME frame.

Configuration

• Add AH.Service.JournalTerminalRetentionSec = 2592000.
• Keep the earlier unmerged AH.Service.JournalAppliedRetentionSec name as a fallback so a staged 0 disable value remains effective.
• Keep AH.Service.JournalPruneIntervalSec = 3600; setting either effective value to 0 disables pruning.
• Advance the AH configuration version to 2026071400.
• Add the worker's required read-only SELECT grant on custody_ledger; no custody write access is added.

Database Coordination

This server change requires character DB 22.5.3 from mangoszero/database#157. Apply that migration before deploying or enabling the updated worker.

Safety

• RESOLVING, CANCEL_PREPARED, and INTENT_PENDING rows are never retention targets.
• Custody-marker presence is checked in the delete itself as well as candidate selection.
• Database failure stops the current drain and leaves remaining rows for the next cadence.
• Plain --selftest remains config-free; an explicit --config opts into DB-backed checks without the scheduler fixture replacing global configuration.

Testing

• Built mangosd, realmd, and ah-service in Release with MSVC.
• Completed a clean CMake install and verified deployed binary hashes match build outputs.
• Passed config-free and DB-backed installed ah-service --selftest runs.
• Passed installed mangosd -t noop, -t ahforwardreserve, and -t ahmutresult.
• Applied Rel22_05_003 from both a clean 22.5.2 schema and an interrupted post-DDL/pre-version state on MariaDB 10.11.
• Verified character DB 22.5.3, both composite index definitions, configuration version/key parity, and clean staged diffs.
• Completed independent re-review with no remaining High or Medium findings.

---

This change is

[MadMaxMangos]

@claude

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 18 complexity · 0 duplication

Metric	Results
Complexity	18
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be827b55d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[AppVeyorBot]

✅ Build Mangos ZERO Server 22.04.423-pxpkcqks completed (commit 5add70e183 by @MadMaxMangos)

[MadMaxMangos]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0e2e6fe89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[AppVeyorBot]

✅ Build Mangos ZERO Server 22.04.423-blmmdoki completed (commit 00d7b59d05 by @MadMaxMangos)

[MadMaxMangos]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c9b236b9c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[AppVeyorBot]

✅ Build Mangos ZERO Server 22.04.423-wrroodbr completed (commit 325de34b21 by @MadMaxMangos)