fix(project): never block on git state; validate through git's lens - #143
Merged
Conversation
Skill files are enumerated via git ls-files -co --exclude-standard (filesystem walk only outside a repo), so gitignored junk like .DS_Store is invisible to validation and excluded from bundle zips — matching what the tree hash and the platform's clean clone actually contain. Issues gain a severity; warnings render as ⚠ and never affect exit codes or JSON validity. validate no longer touches git state at all. compile downgrades every commit-state condition to a warning: an unresolvable tree hash (no repo / never committed) skips that skill from the output with guidance, and a dirty skill dir warns that the hash reflects HEAD. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgHMhia4ZHmppQ2EYoX1TT Co-authored-by: Orca <help@stably.ai>
josegironn
requested review from
exymax,
jasonzbao and
rishikesh-major
as code owners
July 27, 2026 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the authoring-loop friction reported on
major project validate: gitignored.DS_Storefiles produced dotfile errors, and an uncommitted skill dir hard-failed with "has never been committed to git".git ls-files -co --exclude-standard(tracked + untracked-unignored), with a filesystem-walk fallback outside a repo. Gitignored files are invisible to validation and excluded from bundle zips — matching what the tree hash and the compile job's clean clone actually contain. A non-ignored.DS_Storestill errors (the server rejects it at publish).valid.validatedoes not touch git state at all.compiledowngrades everything: unresolvable tree hash (no repo / never committed) → warning + that skill omitted from output; dirty skill dir → warning that the hash reflects HEAD. Safe because local compile is advisory — the authoritative compile job runs on clean clones where none of these states exist.Repro verified
Uncommitted skill dir with gitignored
.DS_Storeat two levels:validate→✓ Project is valid, exit 0;compile→ one ⚠ skip warning, exit 0; after commit → compiles with tree hash; dirty edit → ⚠ HEAD-hash warning, exit 0; bundle zip contains only git-visible files.🤖 Generated with Claude Code
https://claude.ai/code/session_01KgHMhia4ZHmppQ2EYoX1TT
Made with Orca 🐋