bench(lint): baseline — no prefer-direct-reexport rule - #33
Open
mainframev wants to merge 2 commits into
Open
Conversation
Owner
Author
|
Baseline side of the lint benchmark. Full results and analysis: #34 — summary: the rule adds +1s to a 1148s full workspace lint (+0.09%), below the runner noise floor, and profiles at 0.396 ms per package via ESLint's own profiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Baseline for measuring the lint performance cost of the
prefer-direct-reexportESLint rule.This branch is plain
bench/base(upstreammaster) plus the benchmark CI job only — it contains no rule code.Compare against:
bench/lint-with-rule(the "with rule" PR), which is this branch plus the 4 rule files and nothing else.Method
Both PRs run a byte-identical
lint-benchmarkjob (literally the same commit), so the harness is not a variable:--allnx affectedwould skew asymmetrically--skipNxCachelintiscache: true; otherwise we would time cache replays--excludeTaskDependenciesnx.jsonsetslint.dependsOn: ["build"]; keeps build time out of the measurement--nxBailRun 3× per PR; the fastest run is the least noise-contaminated estimate.
A second, runner-independent measurement runs
TIMING=25 eslint srconreact-components/react-button/libraryand dumps ESLint's per-rule profiler table into the job summary. This matters because the config usesprojectService: true(type-aware linting), so TypeScript program construction may dominate total lint time and swamp the rule's own cost in wall-clock terms.Fork CI enablement
Existing jobs are left untouched — they are gated on
github.repository_owner == 'microsoft'and so skip automatically in this fork, leaving the runner to the new job. The new job is gated ongithub.repository_owner == 'mainframev'.Throwaway branch; not intended to merge.