Skip to content

ci(docker): improve smoke test#32

Open
dargmuesli wants to merge 1 commit into
mainfrom
ci/docker/smoke-improve
Open

ci(docker): improve smoke test#32
dargmuesli wants to merge 1 commit into
mainfrom
ci/docker/smoke-improve

Conversation

@dargmuesli

Copy link
Copy Markdown
Member

This pull request refactors the .github/smoke-test.sh script to simplify container and network naming, improve environment variable handling, and enhance error handling and messaging. The main changes make the script more robust and easier to maintain.

Container and network naming simplification:

  • Renamed Docker containers and network from postgraphile-smoke/postgraphile-smoke-db to smoke/smoke-db, and the network from postgraphile-smoke to smoke.

Environment variable management improvements:

  • Replaced the hardcoded env-vars directory with a dynamically created temporary directory (ENV_DIR) for environment variables, and updated all references accordingly.
  • Updated cleanup logic to remove the temporary environment directory only if it was created.

Robustness and error handling:

  • Improved Docker network creation by checking for existence before creating.
  • Enhanced health check logic to handle containers without a HEALTHCHECK and provide clearer error messages and logs on failure.
  • Updated curl command to include a timeout and improved error handling for failed requests.

Messaging and logging:

  • Updated log and status messages to reflect new container names and clarify output.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the GitHub Actions Docker smoke test script to be more robust and maintainable by simplifying Docker resource naming, improving environment-variable file handling, and strengthening health check and request diagnostics.

Changes:

  • Simplifies container/network naming to smoke, smoke-db, and smoke.
  • Switches env-var file staging to a temporary directory (mktemp -d) and cleans it up on exit.
  • Improves container health checking and adds a request timeout for the GraphQL probe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/smoke-test.sh
Comment thread .github/smoke-test.sh Outdated
@dargmuesli
dargmuesli force-pushed the ci/docker/smoke-improve branch 2 times, most recently from 7122e4b to 984cf68 Compare July 21, 2026 19:26
@dargmuesli
dargmuesli force-pushed the ci/docker/smoke-improve branch from 984cf68 to df3e2dc Compare July 21, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants