chore: sync Rokt kit with upstream v1.30.2 - #1313
Conversation
PR SummaryMedium Risk Overview The kit now records PageView events in
Tests add broad coverage for page-view capture, targeting opt-out, URL sanitization, and Reviewed by Cursor Bugbot for commit 41cb8dc. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41cb8dc. Configure here.
| let pageUrl: string | undefined; | ||
|
|
||
| try { | ||
| pageUrl = sanitizeUrl(window.location.href); |
There was a problem hiding this comment.
Page URL captured after delay
Medium Severity
capturePageView records window.location.href at process time, while other fields come from the event snapshot. When the core SDK queues events (no MPID, integration delay, or config load), navigation before flush stores the wrong pageUrl in page_events sent to Rokt. SDKEvent already carries PageUrl from event creation.
Reviewed by Cursor Bugbot for commit 41cb8dc. Configure here.





Summary
kits/roktfrom upstreammParticle-integrations/mparticle-javascript-integration-roktmainthrough v1.30.2 (dec20cd4).active_time_on_site_mspersistence filtering and page-view capture surfaced aspage_eventsonselectPlacements.@mparticle/web-sdkpeer/dev dependency layout, no standalone semantic-release/provenance config, Vite externalization/aliases/version define, and Node webstorage mitigation.Upstream commits included
315c4f9feat: prevent caching of active_time_on_site_ms attribute (Bump rollup from 1.32.1 to 2.40.0 #106)098aabefeat: capture page views and surface as page_events in selectPlacements (Bump @babel/preset-env from 7.9.6 to 7.13.10 #109)e98e095refactor: rename timeOnPage to activeTimeOnPage in selectPlacements page_events (Bump rollup from 1.32.1 to 2.41.0 #110)12e179dfix: lower PAGE_VIEW_CAPTURE_FAILED severity from WARNING to INFO (Bump rollup from 1.32.1 to 2.41.1 #111)dec20cd4/ v1.30.2 were used for package metadata and changelog only; generateddist/**was not included.Files changed
kits/rokt/src/Rokt-Kit.tskits/rokt/src/selectPlacementsAttributePersistence.tskits/rokt/test/src/tests.spec.tskits/rokt/CHANGELOG.mdkits/rokt/package.jsonkits/rokt/package-lock.jsonkits/rokt/vite.config.tsTest plan
npm ciinkits/rokton Node v24.19.0npm run buildinkits/rokton Node v24.19.0npm testinkits/rokton Node v24.19.0: 228 passednpm ciinkits/rokton Node v26.5.0npm run buildinkits/rokton Node v26.5.0npm testinkits/rokton Node v26.5.0: 228 passedNotes:
npm run buildemits existing declaration-generation type diagnostics from monorepo../../src/vault.ts, but Vite completes successfully. Vitest also warns that the root GTS base tsconfig is not installed from the kit package context.Notes
origin/mainand targetingmain.