Skip to content

fix(publishing): restore Maven Central publishing for isolated kits - #753

Merged
thomson-t merged 2 commits into
mainfrom
fix/isolated-kit-publishing
Aug 6, 2026
Merged

fix(publishing): restore Maven Central publishing for isolated kits#753
thomson-t merged 2 commits into
mainfrom
fix/isolated-kit-publishing

Conversation

@thomson-t

@thomson-t thomson-t commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Background

The 6.0.1 release workflow attempted to publish four Kotlin-isolated kits from
their standalone Gradle roots. Those builds could not access the root-only
buildSrc publication convention, so the Maven Central publication task was
not registered and the isolated artifacts were not published.

What Has Changed

  • Move the Maven publication convention from buildSrc into shared
    build-logic that is available to root, aggregate-kit, and standalone-kit
    builds.
  • Configure stable artifact IDs and exact release-version resolution for
    urbanairship-20, braze-43, ga-23, and ga4-23.
  • Validate generated POMs for Maven Central publication and run Maven-local
    smoke tests before uploading release artifacts.
  • Update the draft and publish workflows to validate every isolated kit before
    Maven Central uploads.
  • Document the isolated-kit coordinates, development workflow, and
    post-release verification process.

Screenshots/Video

N/A — build and release workflow changes only.

Checklist

  • Self-review completed
  • Tests added or updated
  • Tested locally

Move Maven publication conventions into shared build logic so isolated
Kotlin kit builds expose the same Central publishing tasks as root builds.

Validate core, aggregate, and isolated artifacts in Maven Local before
uploading them, and pin isolated kit dependencies to the release version.

#agentic
@thomson-t
thomson-t requested a review from a team as a code owner August 6, 2026 13:20
@cursor

cursor Bot commented Aug 6, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes affect release-time Maven publishing and CI validation for four isolated kits; runtime SDK behavior is unchanged, but a misconfiguration could block or mis-publish release artifacts.

Overview
Restores Maven Central publishing for Kotlin-isolated kits (urbanairship-20, braze-43, ga-23, ga4-23) by wiring those standalone Gradle roots into shared build-logic via includeBuild, applying mparticle.android.library.publish, and pinning stable mparticleMavenPublish.artifactId / VERSION resolution.

Release safety: POM validation now runs before Maven Central uploads (not only mavenLocal), and Release - Draft / Release - Publish add Maven-local smoke tests for aggregate kits plus each isolated kit. Isolated Central publish steps switch from -PisRelease=true to -Pmparticle.kit.mparticleFromMavenLocalOnly=true.

Docs and README tables are updated for the new coordinates and publishMavenPublicationToMavenLocal workflow; build-logic drops redundant AGP/Kotlin classpath deps.

Reviewed by Cursor Bugbot for commit 22aff9a. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 01ea777. Configure here.

Comment thread .github/workflows/release-publish.yml
Comment thread .github/workflows/release-publish.yml
Comment thread .github/workflows/release-publish.yml Outdated
@thomson-t
thomson-t merged commit b5a1d8a into main Aug 6, 2026
42 checks passed
@thomson-t
thomson-t deleted the fix/isolated-kit-publishing branch August 6, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants