Fix DocumentationSearch asset compatibility recovery - #189
Conversation
Treat text encoder initialization failures as provider failures, select and retry documentation assets by Xcode and host compatibility, and preserve the installed fallback across concurrent native responses.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfc4319c28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Prioritize assets that do not target a newer host OS and prevent the service repairer from persisting an ineligible configuration when no host-compatible asset exists.
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Purpose
Recover
DocumentationSearchwhen Xcode advertises the tool but its selected documentation asset cannot initialize the text embedding model.The proxy previously treated the latest installed documentation asset as universally executable and passed through
Text encoding failedtool errors without attempting the installed-asset recovery path.Changes
Testing
swift test --filter DocumentationProviderTests -Xswiftc -strict-concurrency=minimal(126 tests)scripts/check.sh:swift test --no-parallel -Xswiftc -strict-concurrency=minimal(1,033 tests)XCODE_MCP_RUN_PROCESS_TESTS=1 swift test --no-parallel --filter XcodeMCPProcessRuntimeTests -Xswiftc -strict-concurrency=minimal(24 tests)XCODE_MCP_RUN_PROCESS_TESTS=1 swift test --no-parallel --filter ProxyStdioAdapterTests -Xswiftc -strict-concurrency=minimal(13 tests)git diff --checkEstimationTechniquesearches against an isolated branch server; both returnedOKwith the Vision documentation result.mainbase completed with no findings after four rounds.