Skip to content

fix: add spring-core test dependency for spring-security-crypto 7.x#71

Merged
sebveit merged 1 commit into
lucimber:mainfrom
sebveit:fix/spring-core-test-dep
Jun 25, 2026
Merged

fix: add spring-core test dependency for spring-security-crypto 7.x#71
sebveit merged 1 commit into
lucimber:mainfrom
sebveit:fix/spring-core-test-dep

Conversation

@sebveit

@sebveit sebveit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

spring-security-crypto 7.1.0's AbstractValidatingPasswordEncoder#matches references org.springframework.util.StringUtils (in spring-core), which spring-security-crypto declares as an optional dependency. Gradle therefore does not resolve it transitively, so the class is absent from the test classpath and every SpringSecurityIntegrationTest case fails on a clean dependency resolution with NoClassDefFoundError (as seen in CI).

Add spring-core 7.0.8 (the Spring Framework 7.0.x line that Spring Security 7.1.0 targets) to the test classpath.

Description

Brief description of what this PR does.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)

Related Issue

Fixes #65

Changes Made

  • Add spring-core 7.0.8 (the Spring Framework 7.0.x line that Spring Security 7.1.0 targets) to the test classpath.

Testing

  • Unit tests pass locally (./gradlew test)
  • Integration tests pass (./gradlew test --tests "*IntegrationTest")
  • New tests added for new functionality
  • All tests achieve 100% pass rate

Test Coverage

  • New code is covered by tests
  • Edge cases are tested
  • Error conditions are tested

Compatibility

  • Verified compatibility with Spring Security
  • Verified compatibility with Bouncy Castle
  • No breaking changes to public API

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added Javadoc for all public methods
  • I have updated the CHANGELOG.md if needed

Screenshots (if applicable)

Add screenshots here if UI/visual changes.

Additional Notes

Any additional information that reviewers should know.

spring-security-crypto 7.1.0's AbstractValidatingPasswordEncoder#matches references org.springframework.util.StringUtils (in spring-core), which spring-security-crypto declares as an optional dependency. Gradle therefore does not resolve it transitively, so the class is absent from the test classpath and every SpringSecurityIntegrationTest case fails on a clean dependency resolution with NoClassDefFoundError (as seen in CI).

Add spring-core 7.0.8 (the Spring Framework 7.0.x line that Spring Security 7.1.0 targets) to the test classpath.

Signed-off-by: Sebastian Veit <sebastian.veit@lucimber.com>
@github-actions github-actions Bot added area: build Build system, Gradle configuration area: dependencies Dependency updates or issues community-contribution Contribution from community member semver: patch Patch version bump required size: XS Extra small PR (< 10 lines) status: needs-review Needs code review type: bug Something isn't working labels Jun 25, 2026
@sebveit
sebveit merged commit 6beea8f into lucimber:main Jun 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build system, Gradle configuration area: dependencies Dependency updates or issues community-contribution Contribution from community member semver: patch Patch version bump required size: XS Extra small PR (< 10 lines) status: needs-review Needs code review type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant