fix: add spring-core test dependency for spring-security-crypto 7.x#71
Merged
Merged
Conversation
spring-security-crypto 7.1.0's AbstractValidatingPasswordEncoder#matches references org.springframework.util.StringUtils (in spring-core), which spring-security-crypto declares as an optional dependency. Gradle therefore does not resolve it transitively, so the class is absent from the test classpath and every SpringSecurityIntegrationTest case fails on a clean dependency resolution with NoClassDefFoundError (as seen in CI). Add spring-core 7.0.8 (the Spring Framework 7.0.x line that Spring Security 7.1.0 targets) to the test classpath. Signed-off-by: Sebastian Veit <sebastian.veit@lucimber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-security-crypto 7.1.0's AbstractValidatingPasswordEncoder#matches references org.springframework.util.StringUtils (in spring-core), which spring-security-crypto declares as an optional dependency. Gradle therefore does not resolve it transitively, so the class is absent from the test classpath and every SpringSecurityIntegrationTest case fails on a clean dependency resolution with NoClassDefFoundError (as seen in CI).
Add spring-core 7.0.8 (the Spring Framework 7.0.x line that Spring Security 7.1.0 targets) to the test classpath.
Description
Brief description of what this PR does.
Type of Change
Related Issue
Fixes #65
Changes Made
Testing
./gradlew test)./gradlew test --tests "*IntegrationTest")Test Coverage
Compatibility
Checklist
Screenshots (if applicable)
Add screenshots here if UI/visual changes.
Additional Notes
Any additional information that reviewers should know.