chore(deps): migrate web to React 19 - #48
Merged
Merged
Conversation
Bumps the react group (react, react-dom, @types/react, @types/react-dom) to v19
across @cloakcode/web and @cloakcode/web-playground. React 19 removed the global
JSX namespace, so import { type JSX } from "react" in the six components that
annotate JSX.Element return types. No runtime API changes were needed (already
on createRoot; useRef calls all pass an initial value).
Supersedes Dependabot #46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #46 (adds the code migration Dependabot can't do).
What
Bumps the react group —
react,react-dom,@types/react,@types/react-dom— from 18.3.1 to 19.2.7 across@cloakcode/weband@cloakcode/web-playground.Migration
React 19 removed the global
JSXnamespace (it now lives underReact.JSX), so the six components that annotateJSX.Elementreturn types nowimport { type JSX } from "react". That's the only code change needed:createRoot(no legacyReactDOM.render).useRefcalls pass an initial value (React 19 requires an argument).forwardRef/findDOMNode/PropTypes/defaultProps/ string refs anywhere.@testing-library/react@16and@vitejs/plugin-react@6already support React 19.Validation
typecheck+build+lintclean for both packages;pnpm --filter @cloakcode/web test= 131 passed. No new warnings (whatwg-encodingdeprecation is pre-existing from jsdom).Guardrails
Pure
@cloakcode/web/web-playgroundchange; novscodeimport; no code-sync/egress path; no secrets logged.