#74: Review gate before auto-merge in /afk (AI Reviewer step)#75
Merged
Conversation
- reduce.ts: afk SandboxFinished → StartReview (not EnableAutoMerge);
ReviewFinished{pass} → EnableAutoMerge, {changes-requested} → WaitForHuman;
reviewVerdict() fail-safe mapper; hitl path unchanged
- reviewer-adapter.ts: two-pass produce→extract reviewer sandbox (noSandbox,
read-only); parseDiffLines + filterInlineComments guard; Output.object schema
validation; null on any failure (fail-safe)
- review-prompt.md / review-extraction.md: reviewer prompts
- issue-source.ts: getPrDiff() + postPrReview() (gh api with JSON stdin)
- main.ts: handle StartReview — run reviewer, dispatch ReviewFinished, post
review on changes-requested; instantiate ReviewerAdapter from AGENTIC_MODEL
- docs/adr/0020-review-gate-before-auto-merge.md: ADR amending ADR-0007
- reduce.test.ts: full reducer + reviewVerdict unit tests (type-cast fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Implemented autonomously by the AFK orchestrator in an isolated, git-isolated sandbox.
Commits: 730d300