#72: Lean execution layer: adopt sandcastle's high-level sandbox lifecycle#73
Merged
Conversation
Switch SandboxRunner from run() to createSandbox + await using +
hooks.onSandboxReady + promptFile/promptArgs so the library owns
worktree creation and deterministic teardown instead of the adapter.
- SandboxRunner.runIssue uses `await using sandbox = await createSandbox()`
then `sandbox.run()` with promptFile/promptArgs; scope-bound disposal
replaces bespoke try/finally teardown
- buildAgentInput extended to accept IssueInput; returns the full config
for both createSandbox() and sandbox.run() (agent, imageName, network,
copyToWorktree, onSandboxReady, promptFile, promptArgs)
- In-sandbox setup (opencode.json relocation) moves to hooks.onSandboxReady
- Agent prompts move to prompt-claude.md / prompt-local.md templates with
{{ISSUE_NUMBER}}/{{ISSUE_TITLE}}/{{ISSUE_BODY}} substitution via promptArgs
- buildPrompt/buildLocalPrompt string builders removed
- 6 new unit tests covering promptFile, promptArgs, and network forwarding
- ADR-0019 records the two asymmetries that stay imperative (MTU creation,
socat host override) and their relation to ADR-0006/0013 and #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
Implemented autonomously by the AFK orchestrator in an isolated, git-isolated sandbox.
Commits: 45f412f