set n-pages in SetAnimationProperties to match pages written - #4578
Open
metsw24-max wants to merge 1 commit into
Open
set n-pages in SetAnimationProperties to match pages written#4578metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale n-pages on animated output
SetAnimationProperties sets page-height on the output image but leaves n-pages at the value the loader recorded for the input file, so
info.pagesreports the source page count rather than the number actually written:sharp(animated, { pages: 2 })reports 30 alongside a height of 160 and a pageHeight of 80, and the same stale count is persisted tovoutput. Setting it beside page-height keeps the pair consistent, which is what the raw/create input paths and the animated join already do.