Wire AABB/procedural geometry through the Pipeline-level AS builder#1395
Closed
bogner wants to merge 1 commit into
Closed
Wire AABB/procedural geometry through the Pipeline-level AS builder#1395bogner wants to merge 1 commit into
bogner wants to merge 1 commit into
Conversation
Routes BLASDesc.AABBs through the Pipeline -> API conversion in buildPipelineAccelerationStructures(), populating the BLASBuildRequest Geometry variant with either SmallVector<AABBGeometryDesc> or SmallVector<TriangleGeometryDesc> based on which geometry list is populated (mixed and empty cases now error explicitly). The DX/VK/MTL AABB build paths were already in place. The covering test defines a single AABB, fires a ray through it, and in the candidate loop calls CommitProceduralPrimitiveHit(); CommittedStatus() must return COMMITTED_PROCEDURAL_PRIMITIVE_HIT. Part of the inline-RT test coverage epic (llvm#1258). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
Contributor
Author
|
We'll finish this in #1289 after all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a commandeer of #1289 so that I could resolve the conflicts and get it merged.
Original message:
Routes BLASDesc.AABBs through the Pipeline -> API conversion in buildPipelineAccelerationStructures(), populating the BLASBuildRequest Geometry variant with either SmallVector or SmallVector based on which geometry list is populated (mixed and empty cases now error explicitly). The DX/VK/MTL AABB build paths were already in place. The covering test defines a single AABB, fires a ray through it, and in the candidate loop calls CommitProceduralPrimitiveHit(); CommittedStatus() must return COMMITTED_PROCEDURAL_PRIMITIVE_HIT.
Part of the inline-RT test coverage epic
(#1258).
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com